From Dan Kenigsberg <dan...@redhat.com>:

Hello Jenkins CI, gerrit-hooks, Petr Horáček, Leon Goldberg, Edward Haas,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/80178

to review the following change.

Change subject: net build, take 2: Unify module collection on the network dir 
......................................................................

net build, take 2: Unify module collection on the network dir 


In order to simplify and reduce the overhead when adding new modules under the 
vdsm/network package, all *.py files are collected by the makefile and all 
*.py* are specified in the spec.

Change-Id: I285aeb23b76008285a2a5ab0b176a66b7a6953d3
---
M lib/vdsm/network/Makefile.am
M vdsm.spec.in
2 files changed, 2 insertions(+), 46 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/80178/1

diff --git a/lib/vdsm/network/Makefile.am b/lib/vdsm/network/Makefile.am
index abf1db6..cba43d7 100644
--- a/lib/vdsm/network/Makefile.am
+++ b/lib/vdsm/network/Makefile.am
@@ -22,27 +22,4 @@
 include $(top_srcdir)/build-aux/Makefile.subs
 
 vdsmnetworkdir = $(vdsmpylibdir)/network
-dist_vdsmnetwork_PYTHON = \
-       __init__.py \
-       api.py \
-       errors.py \
-       canonicalize.py \
-       cmd.py \
-       connectivity.py \
-       dhclient_monitor.py \
-       driverloader.py \
-       ifacetracking.py \
-       ifacquire.py \
-       initializer.py \
-       ipwrapper.py \
-       kernelconfig.py \
-       legacy_switch.py \
-       models.py \
-       netconfpersistence.py \
-       netrestore.py \
-       netupgrade.py \
-       py2to3.py \
-       restore_net_config.py \
-       sourceroute.py \
-       sysctl.py \
-       $(NULL)
+dist_vdsmnetwork_PYTHON = *.py
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 8b65a1e..55d61a1 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1077,30 +1077,17 @@
 %{python_sitelib}/%{vdsm_name}/moduleloader.py*
 %{python_sitelib}/%{vdsm_name}/momIF.py*
 %{python_sitelib}/%{vdsm_name}/mkimage.py*
-%{python_sitelib}/%{vdsm_name}/network/__init__.py*
-%{python_sitelib}/%{vdsm_name}/network/api.py*
+%{python_sitelib}/%{vdsm_name}/network/*.py*
 %{python_sitelib}/%{vdsm_name}/network/configurators/__init__.py*
 %{python_sitelib}/%{vdsm_name}/network/configurators/ifcfg.py*
 %{python_sitelib}/%{vdsm_name}/network/configurators/ifcfg_acquire.py*
 %{python_sitelib}/%{vdsm_name}/network/configurators/qos.py*
-%{python_sitelib}/%{vdsm_name}/network/errors.py*
-%{python_sitelib}/%{vdsm_name}/network/canonicalize.py*
-%{python_sitelib}/%{vdsm_name}/network/cmd.py*
-%{python_sitelib}/%{vdsm_name}/network/connectivity.py*
-%{python_sitelib}/%{vdsm_name}/network/dhclient_monitor.py*
-%{python_sitelib}/%{vdsm_name}/network/driverloader.py*
 %{python_sitelib}/%{vdsm_name}/network/ip/*.py*
 %{python_sitelib}/%{vdsm_name}/network/ip/address/*.py*
 %{python_sitelib}/%{vdsm_name}/network/ip/route/*.py*
 %{python_sitelib}/%{vdsm_name}/network/ip/rule/*.py*
-%{python_sitelib}/%{vdsm_name}/network/ifacetracking.py*
-%{python_sitelib}/%{vdsm_name}/network/ifacquire.py*
-%{python_sitelib}/%{vdsm_name}/network/initializer.py*
-%{python_sitelib}/%{vdsm_name}/network/ipwrapper.py*
 %{python_sitelib}/%{vdsm_name}/network/link/*.py*
 %{python_sitelib}/%{vdsm_name}/network/link/bond/*.py*
-%{python_sitelib}/%{vdsm_name}/network/kernelconfig.py*
-%{python_sitelib}/%{vdsm_name}/network/legacy_switch.py*
 %{python_sitelib}/%{vdsm_name}/network/netinfo/*.py*
 %{python_sitelib}/%{vdsm_name}/network/netlink/__init__.py*
 %{python_sitelib}/%{vdsm_name}/network/netlink/addr.py*
@@ -1118,14 +1105,6 @@
 %{python_sitelib}/%{vdsm_name}/network/ovs/validator.py*
 %{python_sitelib}/%{vdsm_name}/network/ovs/driver/__init__.py*
 %{python_sitelib}/%{vdsm_name}/network/ovs/driver/vsctl.py*
-%{python_sitelib}/%{vdsm_name}/network/models.py*
-%{python_sitelib}/%{vdsm_name}/network/netconfpersistence.py*
-%{python_sitelib}/%{vdsm_name}/network/netrestore.py*
-%{python_sitelib}/%{vdsm_name}/network/netupgrade.py*
-%{python_sitelib}/%{vdsm_name}/network/py2to3.py*
-%{python_sitelib}/%{vdsm_name}/network/restore_net_config.py*
-%{python_sitelib}/%{vdsm_name}/network/sourceroute.py*
-%{python_sitelib}/%{vdsm_name}/network/sysctl.py*
 %{python_sitelib}/%{vdsm_name}/network/tc/__init__.py*
 %{python_sitelib}/%{vdsm_name}/network/tc/_parser.py*
 %{python_sitelib}/%{vdsm_name}/network/tc/_wrapper.py*


-- 
To view, visit https://gerrit.ovirt.org/80178
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I285aeb23b76008285a2a5ab0b176a66b7a6953d3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgold...@redhat.com>
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to