From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: api: ping2 and confirmConnectivity ...................................................................... Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/80119/5/tests/functional/utils.py File tests/functional/utils.py: Line 173: def pinger(self): Line 174: """Keeps pinging vdsm for operations that need it""" Line 175: def ping(): Line 176: while not done: Line 177: self.vdscli.ping2() why do we need the ping2 call? can we drop it (and rename the function accordingly)? Line 178: self.vdscli.confirmConnectivity() Line 179: time.sleep(1) Line 180: try: Line 181: done = False -- To view, visit https://gerrit.ovirt.org/80119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f93e88e37288ae1689b6a43014817af655f191e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horacek <phora...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
