From Dan Kenigsberg <dan...@redhat.com>:

Dan Kenigsberg has posted comments on this change.

Change subject: virt net: Avoid removing the display network when not defined
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/80393/1/lib/vdsm/virt/vmdevices/graphics.py
File lib/vdsm/virt/vmdevices/graphics.py:

Line 70:             display_ip = '0'
Line 71:         self.specParams['displayIp'] = display_ip
Line 72: 
Line 73:     def teardown(self):
Line 74:         display_network = self.specParams['displayNetwork']
nice, more symmetrical vs setup()
Line 75:         if display_network:
Line 76:             libvirtnetwork.delete_network(display_network, self.vmid)
Line 77: 
Line 78:     def getSpiceVmcChannelsXML(self):


-- 
To view, visit https://gerrit.ovirt.org/80393
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd3faedd952a53bbd36a3e101079a65c8f6cf1ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to