Adam Litke has posted comments on this change. Change subject: dd: use iflag=direct only when supported by the os ......................................................................
Patch Set 3: Looks good to me, but someone else must approve I think the debate comes down to one question: Is it an error if a caller asks for a file to be opened O_DIRECT but for some reason O_DIRECT is not possible. In my opinion, O_DIRECT is an advisory/optimization. In other words, if it is not honored vdsm will still function correctly (albeit maybe with lower performance). Given this, I would say it is not an error to silently drop the O_DIRECT flag for paths where it is not supported. -- To view, visit http://gerrit.ovirt.org/9661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76f3ac6a9c220e34f78d0d922145bca56ee8e10e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
