Shu Ming has posted comments on this change.
Change subject: Adding check of os.access to vdsm log file during startup
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/vdsm
Line 120:
Line 121:
Line 122: def __assertVdsmUser():
Line 123: username = getpass.getuser()
Line 124: if username != constants.VDSM_USER:
Do you have a specific reason to replace assert with a if condition check here?
assert only effect in when python built-in variable __debug__ is true.
However, the if condition effect in any case. So they are different.
Line 125: syslog.syslog("VDSM failed to start: running user is not %s,
trying "
Line 126: "to run from user %s" % (constants.VDSM_USER,
username))
Line 127: sys.exit(1)
Line 128: group = grp.getgrnam(constants.VDSM_GROUP)
--
To view, visit http://gerrit.ovirt.org/9700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I578bdfaa199afc2d5f154a1de12241e02b1ca1a4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
