Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix duplicate emulated machines returned
......................................................................
Fix duplicate emulated machines returned
On Fedora, libvirt call getCapabilities() also append the list of emulated
machines to the 'domain' node whose type is 'kvm'. The list is identical to
what's listed in the default info of that arch. So it would cause
getElementsByTagName('machine') matches all of machine tags and return a list
of duplidate emuated machines.
This patch changes to only collect information from the direct children of
tag 'arch' and adds a test case for it.
Change-Id: I7e28688bf09b5bc413afffe9cc1501d4247d67e0
Signed-off-by: Mark Wu <[email protected]>
---
M tests/capsTests.py
M tests/caps_libvirt.out
M vdsm/caps.py
3 files changed, 84 insertions(+), 41 deletions(-)
Approvals:
Adam Litke: Looks good to me, but someone else must approve
Hunt Xu: Looks good to me, but someone else must approve
Mark Wu: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8208
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e28688bf09b5bc413afffe9cc1501d4247d67e0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Hunt Xu <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
