Dan Kenigsberg has posted comments on this change. Change subject: isRunning didn't check local variable before reading saved data ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/supervdsm.py Line 143: self._svdsm = None Line 144: self._firstLaunch = True Line 145: Line 146: def isRunning(self): Line 147: if self._firstLaunch or self._svdsm is None: why have you added a test of self._firstLaunch? I'm only saying that this test is not safe, as self._firstLaunch may change right after it. Line 148: return False Line 149: Line 150: try: Line 151: with open(self.pidfile, "r") as f: -- To view, visit http://gerrit.ovirt.org/10491 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dec0c6955dadcd959cc1c8df4e9745322fb0ce3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
