Federico Simoncelli has posted comments on this change. Change subject: Storage: Check that underlying file system supports direct IO ......................................................................
Patch Set 6: (1 inline comment) .................................................... File vdsm/storage/fileSD.py Line 62: Line 63: Line 64: def validateFileSystemFeatures(sdUUID, mountDir): Line 65: try: Line 66: # Don't unlink this file, we don't have the cluster lock yet as it I don't think my ocd can live with this double indentation. Line 67: # requires direct IO which is what we are trying to test for. This Line 68: # means that unlinking the file might cause a reace. Since we don't Line 69: # care what the content of the file is, just that we managed to Line 70: # open it O_DIRECT. -- To view, visit http://gerrit.ovirt.org/9749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf14d1c4737a88e693e5bebb896aef382b8b424c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: humble devassy <hchir...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches