Federico Simoncelli has posted comments on this change. Change subject: clusterlock: add the local locking implementation ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/storage/clusterlock.py Line 156: self._sdUUID = sdUUID Line 157: self._idsPath = idsPath Line 158: self._leasesPath = leasesPath Line 159: self._sanlockfd = None Line 160: self._initImpl = SANLockInit(sdUUID, idsPath, leasesPath) Did you comment in wrong place? This is the SANLock implementation. Maybe you meant line 279. Am I missing something? Line 161: Line 162: def initLock(self): Line 163: self._initImpl.initLock() Line 164: -- To view, visit http://gerrit.ovirt.org/10282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I106618a9a61cc96727edaf2e3ab043b2ec28ebe1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches