Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: Rearrange test classes for reusability ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm_api/jsonrpc/client.py Line 11: try: Line 12: import proton Line 13: from jsonrpc import protonReactor Line 14: proton # Squash pyflakes error for Line 15: protonReactor # unused import why is it imported? If "import protonReactor" fails (after "import proton" succeeds), we would not notice it. So I do not understand the purpose of this. Line 16: except ImportError: Line 17: pass Line 18: Line 19: -- To view, visit http://gerrit.ovirt.org/11122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78f9546c0bfb2348510340922ba95569b1827830 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
