Federico Simoncelli has posted comments on this change. Change subject: misc: handle properly timeout=-1 in NoIntrPoll ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/storage/misc.py Line 1376: except (IOError, select.error) as e: Line 1377: if e.args[0] != errno.EINTR: Line 1378: raise Line 1379: Line 1380: if endtime is not None: We can use "timeout" here as you suggest but nonetheless the operand that can cause trouble is "endtime" (see next line). I prefer to test the relevant operand rather than a different variable on which it is depending. Line 1381: timeout = max(0, endtime - time.time()) Line 1382: Line 1383: Line 1384: def isAscii(s): -- To view, visit http://gerrit.ovirt.org/11394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefc4d17559d3335ef6699cb83923c3bd255c916b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Royce Lv <lvro...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
