Federico Simoncelli has posted comments on this change. Change subject: image: update the volume permissions when needed ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/storage/fileSD.py Line 416: """ Line 417: # Volumes leaves created in 2.2 did not have group writeable bit Line 418: # set. We have to set it here if we want qemu-kvm to write to old Line 419: # NFS volumes. Line 420: vol = self.produceVolume(imgUUID, volUUIDs[-1]) When I started I fell into this misconception too (looping on all volumes). Then when I wrote the commit message I realized that this is just to support V1 coming from 2.2 (no live snapshots/merge). On domain upgrade (to V3) all the permissions will be updated accordingly. Line 421: self.oop.fileUtils.copyUserModeToGroup(vol.getVolumePath()) Line 422: Line 423: @classmethod Line 424: def format(cls, sdUUID): -- To view, visit http://gerrit.ovirt.org/13331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I516d8240840e3aa32bd8074420e331b8dc4e6da7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
