Dan Kenigsberg has posted comments on this change. Change subject: stats: report the domain version ......................................................................
Patch Set 6: I would prefer that you didn't submit this (1 inline comment) .................................................... Commit Message Line 6: Line 7: stats: report the domain version Line 8: Line 9: VDSM should provide to the engine a way to determine if a domain (other Line 10: than the master) has been upgraded or not. neither the commit message not the bug report suggest why it is good an useful to report the version per domain. iirc, the idea behind version upgrade was that an upgrade is performed blindly, upon domain activation. Would you care to explain the motivation for this api change? Line 11: Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=951057 Line 13: Change-Id: I88884356eefcd5040deccbf34eab271be8dbc522 -- To view, visit http://gerrit.ovirt.org/13620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88884356eefcd5040deccbf34eab271be8dbc522 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
