Vinzenz Feenstra has posted comments on this change. Change subject: Added unit test libvirtvmTests.py:TestLibvirtvm.testBuildCmdLine ......................................................................
Patch Set 3: I would say it'd be better if we could put the input for the scenarios and expected outputs into external files and load them from there and compare the results then. That would add more flexibility in writing the configurations and expected outputs. Currently you have basically just 2 large strings containing the data. If you need to modify values in there, you could use some kind of template engine approach and replace the values on load. -- To view, visit http://gerrit.ovirt.org/14111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74b898a6398a72608d7933009644703aa3f8d831 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maciej Lichon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Maciej Lichon <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
