Michal Skrivanek has posted comments on this change. Change subject: vdsm: fix RTC offset ......................................................................
Patch Set 1: (1 inline comment) .................................................... Commit Message Line 6: Line 7: vdsm: fix RTC offset Line 8: Line 9: Upon RTC update (hwclock --systohc) on the guest side, libvirt sends the event Line 10: with RTC offset from the qemu start -rtc value in seconds. The received offset If I'm not mistaken the offset is against the initial value. Not the previous one. So no harm done if we miss an event. We just base it to the original qemu parameter we passed. In any case it seems to me only reasonable to not pass any TZ to Linux OSes as all distros are using UTC as default Line 11: should not replace the previous value, but should be added to it. Since the Line 12: time update event is relative to the qemu start time, we should store the Line 13: initial value and use it for the calculation. Line 14: -- To view, visit http://gerrit.ovirt.org/14750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
