Mark Wu has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ......................................................................
Patch Set 12: No score (1 inline comment) .................................................... File vdsm/netmodels.py Line 169: raise ConfigNetworkError( Line 170: ne.ERR_USED_NIC, 'nic %s already used by %s' % Line 171: (nic, nicVlans or nicNet or nicBond)) Line 172: slaves.append(Nic.objectivize(nic, configurator, mtu, Line 173: _netinfo)) Please ignore this one. It's pep8 compliant. Line 174: elif name in _netinfo.bondings: # Implicit bonding. Line 175: mtu = max(int(netinfo.getMtu(name)), mtu) Line 176: slaves = [Nic.objectivize(nic, configurator, mtu, _netinfo) Line 177: for nic in _netinfo.getNicsForBonding(name)] -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
