Deepak C Shetty has posted comments on this change. Change subject: WIP: storage: Introduce prepareBackupDisk vdsm verb ......................................................................
Patch Set 4: (1 inline comment) Added some Qs on how to return the export Disk info from hsm.py .................................................... File vdsm/storage/hsm.py Line 3145: nbdPath = snapVol.exportAsNbd(sockType) Line 3146: Line 3147: cbtInfo = snapVol.queryCBTInfo() Line 3148: return dict(protocol=sockType, path=nbdPath, cbtInfo=cbtInfo) Line 3149: I was thinking about how to return the export disk as ? Eventually the disk info returned from here will be used as-is as part of "attach disk to Backup VM".. which will result in VM.hotplugDisk(params) verb of vdsm to be called. So instead of returning just the nbdPath, i feel i should return a proper drive dict which can then be passed as-is to the hotplugDisk vdsm verb ? Thoughts ? Line 3150: @public Line 3151: def prepareImage(self, sdUUID, spUUID, imgUUID, volUUID=None): Line 3152: """ Line 3153: Prepare an image activating the needed volumes. -- To view, visit http://gerrit.ovirt.org/14403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ccacda2b09810a71f445ed65de6a09336ea3fb1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
