Dan Kenigsberg has posted comments on this change. Change subject: domain: use the dd statistics for the domain delay ......................................................................
Patch Set 2: Looks good to me, approved (1 inline comment) .................................................... File vdsm/storage/misc.py Line 210: def readfile(name, buffersize=None): Line 211: """ Line 212: Read the content of the file using /bin/dd command Line 213: """ Line 214: _rc, out, _err = _readfile(name, buffersize) yeah, it's a bit ugly, but let's not wait for this. Line 215: return out Line 216: Line 217: Line 218: _readspeed_regex = re.compile( -- To view, visit http://gerrit.ovirt.org/15049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3fa54dbbe3475b74bcfe5cbc0c60895818f8b3e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
