Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm-toolize dummybr and nwfilter
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
-1 just for visibility of a very minor style problem. For the rest, I approve.
....................................................
File lib/vdsm/tool/dummybr.py
Line 41: '''name='%s'/></network>''' % (bridgeName, bridgeName))
Line 42:
Line 43: @expose('dummybr')
Line 44: def main():
Line 45: '''
Quoting PEP 257: "For consistency, always use """triple double quotes""" around
docstrings".
Line 46: Defines dummy bridge on libvirt network.
Line 47: '''
Line 48: if not os.path.exists('/sys/class/net/%s' % DUMMY_BRIDGE):
Line 49: createEphemeralBridge(DUMMY_BRIDGE)
--
To view, visit http://gerrit.ovirt.org/15370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id32554824cc231f428523dbd34a3fa189b361ae5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
