Dan Kenigsberg has posted comments on this change. Change subject: WIP: Introduce a base network configurator class ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/netconf/__init__.py Line 24: class Configurator(object): Line 25: Line 26: # TODO: Do all the configWriter interaction from here. Line 27: def __init__(self, configWriter=None): Line 28: self.configWriter = configWriter Could you explain why non-ifcfg configurators need access to configWriter? I'd expect netconf.iproute2 to take care of its atomicity in a completely different form. Line 29: self._libvirtAdded = set() Line 30: Line 31: def _setNewMtu(self, iface, _netinfo=None): Line 32: """ -- To view, visit http://gerrit.ovirt.org/15300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I672c4d671ae2a9d6c6eeede051e7989d58b8c005 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
