Antoni Segura Puimedon has posted comments on this change.

Change subject: tests: Adding functional tests for networking
......................................................................


Patch Set 12: (1 inline comment)

....................................................
File tests/functional/utils.py
Line 88:             # cleanup
Line 89:             cmd_service = [service.cmd, "vdsm-restore-net-config", 
"start"]
Line 90:             utils.execCmd(cmd_service, sudo=True)
Line 91:             # keeps traceback
Line 92:             import sys
can't you just reraise doing:
raise
Line 93:             exc_info = sys.exc_info()
Line 94:             raise exc_info[0], exc_info[1], exc_info[2]
Line 95:     return wrapper
Line 96: 


--
To view, visit http://gerrit.ovirt.org/14840
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3be71db9dc0b92c443b87e22fe06f920055c4d3
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to