Antoni Segura Puimedon has posted comments on this change. Change subject: WIP: Add iproute2 configurator ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/netconf/iproute2.py Line 42: self.configWriter.configureIp(bridge) Line 43: self.configWriter.configureMtu(bridge) Line 44: self.configWriter.ifup(bridge) Line 45: Line 46: def configureVlan(self, vlan, bridge=None, **opts): We should probably remove bridge from the configure API in a previous or following patch and make the ifcfg configurator get this sort of information from iface.master. Line 47: vlan.device.configure(vlan=vlan.name, **opts) Line 48: self.configWriter.addVlan(vlan) Line 49: if vlan.ip: Line 50: self.configWriter.configureIp(vlan) Line 98: @contextmanager Line 99: def _removeIface(self, iface): Line 100: _netinfo = netinfo.NetInfo() Line 101: self.configWriter.ifdown(iface) Line 102: multiple_usage = _netinfo.ifaceHasMultiUsers(iface.name) I believe it should be multiple_usage = _netinfo.ifaceHasOtherUsers(iface.name) Line 103: yield not multiple_usage Line 104: if multiple_usage: Line 105: self._setNewMtu(iface, _netinfo=_netinfo) Line 106: if iface.master is None: -- To view, visit http://gerrit.ovirt.org/15301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I762cfa30f78c5a46507b86f53e98bcf79dfc5844 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
