Mark Wu has posted comments on this change. Change subject: Simplify setNewMtu() ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm/netconf/ifcfg.py Line 166: if bridge.port: Line 167: bridge.port.remove() Line 168: Line 169: def removeVlan(self, vlan): Line 170: vlan.mtu = netinfo.getMtu(vlan.name) I agree it's not very readable, but I don't like to change the api. So I am going to drop the optimization in line 212-214, then we can drop the code in line 170 too. How do you think of it? Line 171: ifdown(vlan.name) Line 172: self.configWriter.removeVlan(vlan.name) Line 173: vlan.device.remove() Line 174: -- To view, visit http://gerrit.ovirt.org/15355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32e8e0d45b7887af8fd1b003fd4c358826b77289 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
