Dan Kenigsberg has posted comments on this change. Change subject: NetReload: netmodels for delNetwork ......................................................................
Patch Set 12: (1 inline comment) .................................................... File vdsm/netmodels.py Line 195: Line 196: bondObj = cls(name, configurator, slaves=slaves, options=options, Line 197: mtu=mtu) Line 198: if destroy: Line 199: bondObj.destroy = True I find adding attributes conditionally as bad style. It drops the (fake) boundary between objects and dictionaries, and forces usage of hasattr(). Can we set "destroy" to False in __init__? Line 200: return bondObj Line 201: Line 202: @staticmethod Line 203: def validateName(name): -- To view, visit http://gerrit.ovirt.org/14873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e11fd923a4f5d07d069193278f3eadc94f327ec Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
