Dan Kenigsberg has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg ......................................................................
Patch Set 9: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm/netconf/Makefile.am Line 23: Line 24: dist_vdsmnetconf_PYTHON = \ Line 25: __init__.py \ Line 26: ifcfg.py \ Line 27: libvirtCfg.py * time to add the $(NULL) trick. * how about starting to use the all-lowcaps convention of pep8? -- To view, visit http://gerrit.ovirt.org/15178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I798cca309f54c3497b18d83de4ff378f0bb6582b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
