Antoni Segura Puimedon has posted comments on this change. Change subject: Multiple Gateways[1/2]: add sourceRouting module ......................................................................
Patch Set 22: (1 inline comment) .................................................... File vdsm/sourceRoute.py Line 97: route = Route.fromText(entry) Line 98: route.table = table Line 99: if route.device == device: Line 100: routes.append(route) Line 101: except ValueError: This try catch is because routeShowTable gives broadcast and local tables that are rejected by from text for not being the kind of routes we work with. The rejection is in form of exception. Consider this a kind of filtering. Line 102: pass Line 103: Line 104: return routes Line 105: -- To view, visit http://gerrit.ovirt.org/15207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0224d896724b9cdc44215e92f0da0be71fd19038 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
