Dan Kenigsberg has posted comments on this change. Change subject: Multiple Gateways[2/2]: configNetwork integration ......................................................................
Patch Set 9: Looks good to me, approved (1 inline comment) .................................................... File vdsm/sourceRoute.py Line 227: if __name__ == "__main__": Line 228: # This imports are here due to the fact that we only need to create Line 229: # configurators if being used as a standalone script and because otherwise Line 230: # when importing SourceRoute from the configurators, we'd get a circular Line 231: # dependency. We should move main() to another script altogether. On another day. Line 232: from netconf.ifcfg import ConfigWriter Line 233: from netconf.ifcfg import Ifcfg Line 234: from netconf.iproute2 import Iproute2 -- To view, visit http://gerrit.ovirt.org/15528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4415c6ec91ac49c56703d59b99d3a21b328015b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
