Hunt Xu has posted comments on this change. Change subject: ifcfg: Do not reconfigure existing underlaying device for VLANs ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/netconf/ifcfg.py Line 142: Line 143: def removeVlan(self, vlan): Line 144: ifdown(vlan.name) Line 145: self._removeSourceRoute(vlan) Line 146: self.configWriter.removeVlan(vlan.name) The user of a vlan could only be a bridge in a bridged network, and that user would be removed before this function is called. So I think a checking here is not needed. But I'm not that sure, correct me if I miss something. Line 147: Line 148: def _ifaceDownAndCleanup(self, iface, _netinfo): Line 149: """Returns True iff the iface is to be removed.""" Line 150: ifdown(iface.name) -- To view, visit http://gerrit.ovirt.org/16474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a0738c32aefd6eca7fd094ad6f51d8a07353bb2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
