Antoni Segura Puimedon has posted comments on this change. Change subject: netconf: Add dhcp support for iproute2 configurator ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) One very minor thing that I overlooked before. .................................................... File vdsm/netconf/iproute2.py Line 177: execCmd(['mkdir', self.LEASE_DIR]) Line 178: self.leaseFile = (self.LEASE_FILE % self.iface) Line 179: Line 180: def _dhclient(self): Line 181: rc, out, err = execCmd([self.DHCLIENT.cmd, '-1', '-pf', I wonder if we should pass the hostname as well (like initscripts does when it calls dhclient). I guess it is not strictly necessary, but maybe somebody relies on it. Line 182: self.pidFile, '-lf', self.leaseFile, Line 183: self.iface]) Line 184: return rc, out, err Line 185: -- To view, visit http://gerrit.ovirt.org/15492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea88e8693e47fa51edb89c33344332c88c5c964d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
