Antoni Segura Puimedon has posted comments on this change. Change subject: Add iproute2 configurator ......................................................................
Patch Set 4: I would prefer that you didn't submit this (1 inline comment) I found a potential issue that exists also in ifcfg. .................................................... File vdsm/netconf/iproute2.py Line 46: self.configApplier.setIfaceMtu(bridge.name, bridge.mtu) Line 47: self.configApplier.ifup(bridge) Line 48: Line 49: def configureVlan(self, vlan, **opts): Line 50: vlan.device.configure(**opts) Note that there is a patch from Hunt Xu that solves a problem that we currently have in the ifcfg configurator where we reconfigure vlan underlying devices even when they were pre-exisiting (which was bad). We should do it well from the start from the start in the iproute2 configurator. You can see the patch and my comments to it in: http://gerrit.ovirt.org/#/c/16474/2 Line 51: self.configApplier.addVlan(vlan) Line 52: if vlan.ip: Line 53: self.configApplier.setIpConfig(vlan) Line 54: self.configApplier.setIfaceMtu(vlan.name, vlan.mtu) -- To view, visit http://gerrit.ovirt.org/15301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I762cfa30f78c5a46507b86f53e98bcf79dfc5844 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
