Zhou Zheng Sheng has posted comments on this change. Change subject: vdsmd.init.in: break to pieces ......................................................................
Patch Set 9: Thanks Alon! I agree on most of your suggestions. I just have 1 different ideas and 1 question. 1. About putting all tasks in a single file I think the init tasks could be moved to vdsm-tool in future, such as "vdsm-tool mkdirs; vdsm-tool test_space; vdsm-tool libvirt-configure --force". I do not like putting all tasks together in one file. For now I can accept "run_task a; run_task b; run_task c..." In future we can easily change them to be run by vdsm-tool instead of run_task.sh.in. 2. "Move all the include tasks of sysv (rhel/centos and maybe debian) to their designated init.d script" Do you mean we put a start_needed_service.sh to /etc/init.d, and in vdsmd.init.in, we source start_needed_service.sh and call "start_needed_service srvA srvB..." We provide a default implementation of start_needed_service.sh as current in VDSM and the downstream packager can easily write a new one if the default does not fits. Same with shutdown_conflicting_service.sh . -- To view, visit http://gerrit.ovirt.org/14826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c652704000c764c6e6f248605c6a3f4f3af5ace Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
