Mark Wu has posted comments on this change. Change subject: superVdsm: create dir '/var/run/vdsm' before creating pid file ......................................................................
Patch Set 3: (1 inline comment) .................................................... Commit Message Line 3: AuthorDate: 2013-07-15 00:42:35 -0400 Line 4: Commit: Mark Wu <[email protected]> Line 5: CommitDate: 2013-07-15 03:05:42 -0400 Line 6: Line 7: superVdsm: create dir '/var/run/vdsm' before creating pid file it will cause a break on fedora, because it's /var/run is a symbolic of /run which is mounted on a tmpfs. Without this patch supervdsmd fails to start after reboot. Line 8: Line 9: The directory '/var/run/vdsm' is created by the init script of vdsmd, Line 10: but supervdsmd should run before vdsmd. So supervdsmd should ensure Line 11: the direcotry '/var/run/vdsm' exist by itself, otherwise it will fail -- To view, visit http://gerrit.ovirt.org/16835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23b4e6184fcf60383938bca71643c5b177c94f27 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
