Giuseppe Vallarelli has posted comments on this change.
Change subject: QoS host networks: caps now reports QoS for networks.
......................................................................
Patch Set 4: No score
(2 inline comments)
Ok thanks for the feedback I will update the patch accordingly.
....................................................
File lib/vdsm/netinfo.py
Line 53: DEFAULT_MTU = '1500'
Line 54:
Line 55: REQUIRED_BONDINGS = frozenset(('bond0', 'bond1', 'bond2', 'bond3',
'bond4'))
Line 56:
Line 57: Qos = namedtuple('Qos', 'inbound outbound')
We'll get back to this decision in case of need. For now I'll mark it as _ .
Line 58:
Line 59:
Line 60: def _match_name(name, patterns):
Line 61: return any(map(lambda p: fnmatch(name, p), patterns))
Line 159: """
Line 160: nets = {}
Line 161: conn = libvirtconnection.get()
Line 162: allNets = ((net, net.name()) for net in conn.listAllNetworks(0))
Line 163: for net, netname in allNets:
I got your point which is an improvement, my only concern is about changing the
expected dict, I've searched for it and it doesn't look like it's going to be
harmful.
Line 164: if netname.startswith(LIBVIRT_NET_PREFIX):
Line 165: netname = netname[len(LIBVIRT_NET_PREFIX):]
Line 166: nets[netname] = {}
Line 167: xml = minidom.parseString(net.XMLDesc(0))
--
To view, visit http://gerrit.ovirt.org/17218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b9dde8c580b6087ada29bc3b0d682ed638d92f9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <giuse...@openquake.org>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Petr Šebek <pse...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
