Dan Kenigsberg has posted comments on this change.
Change subject: Fix log level for failures in execCmd
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Saggi, what is your "logErr" arg for, then? We could flip its default if you
insist.
Sergey, this patch is based on a 3 month old HEAD. Please rebase.
....................................................
File vdsm/storage/misc.py
Line 238: # Prevent splitlines() from barfing later on
Line 239: out = ""
Line 240:
Line 241: if p.returncode != 0 and logErr:
Line 242: execCmdLogger.warning("FAILED: <err> = %s; <rc> = %d",
repr(err),
using %r is so much cooler than calling repr().
Line 243: p.returncode)
Line 244: else:
Line 245: execCmdLogger.debug("%s: <err> = %s; <rc> = %d",
Line 246: {True: "SUCCESS", False: "FAILED"}
--
To view, visit http://gerrit.ovirt.org/13362
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e5c3ac5bde06ed9083bc9c1662d3b4eddc85034
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
