Sandro Bonazzola has posted comments on this change. Change subject: removeVmFromMonitoredDomains: Copy keys before traversing and deleting items in domainVmIds ......................................................................
Patch Set 1: (1 comment) .................................................... File vdsm/clientIF.py Line 121: except KeyError: Line 122: self.domainVmIds[dom] = set([vmId]) Line 123: Line 124: def removeVmFromMonitoredDomains(self, vmId): Line 125: for dom in list(self.domainVmIds.keys()): Thanks, I didn't know that. Line 126: #only take lock here to allow runVm to take the lock in-between Line 127: with self.domainVmIdsLock: Line 128: try: Line 129: self.domainVmIds[dom].remove(vmId) -- To view, visit http://gerrit.ovirt.org/17655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9767dc7a723ac6c20f68c620d1bfb3292fec4792 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
