Mark Wu has posted comments on this change.
Change subject: Unified network persistence [1/3] - Save running config
......................................................................
Patch Set 13: Code-Review-1
(1 comment)
....................................................
File vdsm/configNetwork.py
Line 399: elif config.get('vars', 'persistence') == 'unified':
Line 400: logging.info('Removing network %s from running configuration',
Line 401: network)
Line 402: _removeRunningConfig(netinfo.NET_CONF_RUN_DIR + network)
Line 403: if bonding:
we still need check if the bonding has other users by
netinfo.ifaceUsers(bonding). if it still has other users, that means it's not
removed, therefore we should not remove it from persistence.
Line 404: logging.info('Removing bond %s from running
configuration',
Line 405: bonding)
Line 406: _removeRunningConfig(netinfo.BOND_CONF_RUN_DIR + bonding)
Line 407:
--
To view, visit http://gerrit.ovirt.org/16699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Petr Šebek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
