Giuseppe Vallarelli has posted comments on this change.
Change subject: Don't down bonds and nics when adding vlan or resizing
......................................................................
Patch Set 7:
(1 comment)
....................................................
File lib/vdsm/netinfo.py
Line 268: return os.path.exists('/sys/class/net/%s/bonding' % dev)
Line 269:
Line 270:
Line 271: def operstate(dev):
Line 272: return open('/sys/class/net/%s/operstate' % dev).read().strip()
What if I use a device that doesn't exist in the host?
It's part of the public interface we should prevent the IOError from happening
or making it private and assuming that the dev exists in the host.
Line 273:
Line 274:
Line 275: def speed(dev):
Line 276: # return the speed of devices that are capable of replying
--
To view, visit http://gerrit.ovirt.org/17491
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3075a2e65f06416c840c6a98689b77555b22e5d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Petr Šebek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
