Zhou Zheng Sheng has posted comments on this change.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
....................................................
File tests/functional/xmlrpcTests.py
Line 225: self.retryAssert(partial(self.assertVmUp, vmid),
Line 226: timeout=3)
Line 227: # 20 % more time on timeout
Line 228: self.retryAssert(partial(self.assertGuestUp, vmid,
targetUptime),
Line 229: timeout=targetUptime * 1.2)
Minor remind, it's better to math.ceil(targetUptime * 1.2), because by default
the sleep and check interval of retryAssert is 1 second.
Line 230:
Line 231: @skipNoKVM
Line 232: def testSimpleVm(self):
Line 233: customization = {'vmId':
'77777777-ffff-3333-bbbb-222222222222',
--
To view, visit http://gerrit.ovirt.org/17893
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I683c9e056137e7a189815bf6be2eb79ee80994cf
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Petr Šebek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
