Giuseppe Vallarelli has posted comments on this change.
Change subject: netmodels: Improve getIpConfig using namedtuple
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Thanks, looks good only a minor comment.
....................................................
File vdsm/netmodels.py
Line 29: import neterrors as ne
Line 30:
Line 31:
Line 32: class NetDevice(object):
Line 33: _ipConfig = namedtuple('ipConfig', 'ipaddr netmask gateway
bootproto \
Here you can use ['ipConfig', 'ipaddr'...] instead of the string to avoid the \
Line 34: async defaultRoute')
Line 35:
Line 36: def __init__(self, name, configurator, ipconfig=None, mtu=None):
Line 37: self.name = name
--
To view, visit http://gerrit.ovirt.org/18167
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53eb3c4b00f33285a1b299ca0adc6611eb99a989
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
