Dan Kenigsberg has submitted this change and it was merged.

Change subject: [1/3] Fix getVlanID() and getVlanDevice().
......................................................................


[1/3] Fix getVlanID() and getVlanDevice().

Previous implementations work only under root privileges.
This patch reimplements both functions to use "ip" tool.

Change-Id: Ieab0f44cf4c4f6f16f81435cb732ccacf57b0767
Signed-off-by: Amador Pahim <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/18180
Reviewed-by: Antoni Segura Puimedon <[email protected]>
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M lib/vdsm/ipwrapper.py
M lib/vdsm/netinfo.py
2 files changed, 15 insertions(+), 13 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Amador Pahim: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18180
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieab0f44cf4c4f6f16f81435cb732ccacf57b0767
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <[email protected]>
Gerrit-Reviewer: Amador Pahim <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to