Amador Pahim has posted comments on this change.
Change subject: [2/3] Add "vlanid" to VLAN information
......................................................................
Patch Set 4: -Verified
(1 comment)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 674: # Since: 4.10.0
Line 675: ##
Line 676: {'type': 'NetInfoVlan',
Line 677: 'data': {'iface': 'str', 'addr': 'str', 'netmask': 'str',
Line 678: 'ipv6addrs': ['str'], 'mtu': 'uint', 'vlanid': 'uint'}}
k. sorry, first time on json schema. Got tricked by mtu, which is uint here
despite being str in needinfo.
Done.
Line 679:
Line 680: ##
Line 681: # @HookScriptInfo:
Line 682: #
--
To view, visit http://gerrit.ovirt.org/18181
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c83a7639bd4219771df0c7b3dd41b8f9806e9f1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <[email protected]>
Gerrit-Reviewer: Amador Pahim <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
