Federico Simoncelli has posted comments on this change.
Change subject: storage: kill ongoing operations on exit
......................................................................
Patch Set 1:
(1 comment)
....................................................
File lib/vdsm/utils.py
Line 517: return [l[:-1] if l.endswith('\n') else l for l in lines]
Line 518:
Line 519:
Line 520: def watchCmd(command, stop, cwd=None, data=None,
recoveryCallback=None,
Line 521: nice=None, ioclass=None, execCmdLogger=logging.root,
right, but the other mistake is in 'execCmd' where it should be False by
default.
Line 522: killOnExit=False):
Line 523: """
Line 524: Executes an external command, optionally via sudo with stop
abilities.
Line 525: """
--
To view, visit http://gerrit.ovirt.org/18074
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6ff67cb687494099e332d2d7b1eb3a293d1b4e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
