Federico Simoncelli has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 10:
(2 comments)
....................................................
File vdsm/storage/blockSD.py
Line 1033: Creates a compatiblity layer for vdsm and qemu-img use.
Line 1034:
Line 1035: srcImgPath: Dir where the image volumes are.
Line 1036: """
Line 1037: sdRunDir = os.path.join("/var/run/vdsm/storage", self.sdUUID)
I'm sure Dan won't mind if we use the "Path definitions" section in
constants.py.in.
Line 1038: imgRunDir = os.path.join(sdRunDir, imgUUID)
Line 1039: fileUtils.createdir(imgRunDir)
Line 1040: for volUUID in volUUIDs:
Line 1041: srcVol = os.path.join(srcImgPath, volUUID)
Line 1061: If the image is based on a template image it will be
activated.
Line 1062: """
Line 1063: volUUIDs = sd.getVolsOfImage(allVols, imgUUID).keys()
Line 1064: lvm.activateLVs(self.sdUUID, volUUIDs)
Line 1065: vgDir = os.path.join("/dev", self.sdUUID)
For this you could just provide a getDomainDevPath method in this class.
Line 1066: return self.linkRunImage(vgDir, imgUUID, volUUIDs)
Line 1067:
Line 1068: def getVolumeLease(self, imgUUID, volUUID):
Line 1069: """
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1...@gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Haim Ateya <hat...@redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
