Deepak C Shetty has posted comments on this change.

Change subject: Add support for transient disk
......................................................................


Patch Set 1: Verified+1

1) create VM

2) take live snap

3) hotplug the snap to the VM (it should create a transient disk and attach 
it). VDSM generated xml is:

Hotplug disk xml: <disk device="disk" snapshot="no" type="file">
    <source file="/var/run/vdsm/3333017d-1278-4bfb-8129-62bded257399"/>
    <target bus="virtio" dev="vda"/>
    <serial>22224c45-6504-4ea1-bd24-12340017dd32</serial>
    <driver cache="writethrough" error_policy="stop" io="threads" name="qemu" 
type="qcow2"/>
</disk>

Verified using virsh that it was indeed hotplugged in

4) Hotunplug it (should remove the disk from the VM and remove the transient 
disk). VDSM generated xml is:

Hotunplug disk xml: <disk device="disk" snapshot="no" type="file">
    <address bus="0x00" domain="0x0000" function="0x0" slot="0x04" type="pci"/>
    <source file="/var/run/vdsm/3333017d-1278-4bfb-8129-62bded257399"/>
    <target bus="virtio" dev="vda"/>
    <serial>22224c45-6504-4ea1-bd24-12340017dd32</serial>
    <driver cache="writethrough" error_policy="stop" io="threads" name="qemu" 
type="qcow2"/>
</disk>

Verified using virsh that it was indeed hot-unplugged.

-- 
To view, visit http://gerrit.ovirt.org/18326
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to