Federico Simoncelli has posted comments on this change. Change subject: Making setStorageDomainDescription the SPM command ......................................................................
Patch Set 4: Code-Review-1 (1 comment) > I dropped an idea to "setStorageDomainDescription" with shared lock instead > of exclusive due to Eduardo review. Eduardo's review mentioned the verb not being an SPM verb and therefore race-prone. That has nothing to do with the getSharedLock/getExcelusiveLock in setStorageDomainDescription. .................................................... File vdsm/storage/hsm.py Line 2703: vars.task.setDefaultException( Line 2704: se.StorageDomainActionError( Line 2705: "sdUUID=%s, description=%s" % (sdUUID, description))) Line 2706: dom = sdCache.produce(sdUUID=sdUUID) Line 2707: vars.task.getExclusiveLock(STORAGE, sdUUID) vars.task.getSharedLock(STORAGE, sdUUID) Line 2708: Line 2709: pool = self.getPool(dom.getPools()[0]) Line 2710: pool.validatePoolSD(sdUUID) Line 2711: pool.setSDDescription(sdUUID, description) -- To view, visit http://gerrit.ovirt.org/17198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idca7b7b6642c222d88a6cd2a94d4033c0c3ef70b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
