Federico Simoncelli has posted comments on this change.

Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support 
GlusterFS SD
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Given that the requirements are almost the same of vdsm-gluster, looks good to 
me.

....................................................
File vdsm.spec.in
Line 199: %endif
Line 200: 
Line 201: # GlusterFS client-side RPMs needed for Gluster SD
Line 202: %if 0%{?with_gluster}
Line 203: Requires: glusterfs >= 3.4.0
Given that we are now adding these requirements in the main package we might 
want to clean them up from the gluster rpm.

Since that might be controversial and we're already late to get this in, I sent 
an additional patch here:

http://gerrit.ovirt.org/#/c/18408

Discussion can continue there.
Line 204: Requires: glusterfs-cli
Line 205: Requires: glusterfs-api
Line 206: Requires: glusterfs-fuse
Line 207: Requires: glusterfs-rdma


-- 
To view, visit http://gerrit.ovirt.org/17994
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If648feec92ed33f24f45550f016ac132a25e6923
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepa...@linux.vnet.ibm.com>
Gerrit-Reviewer: Andrew Cathrow <and...@cathrow.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Vijay Bellur <vbel...@gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to