Zhou Zheng Sheng has posted comments on this change.
Change subject: Add vdsm upstart jobs
......................................................................
Patch Set 5:
(1 comment)
....................................................
File init/upstart/vdsmd.upstart.in
Line 18: status "${srv}" | grep -q start/running
Line 19: else
Line 20: service "${srv}" status >/dev/null 2>&1 || service
"${srv}" start
Line 21: fi
Line 22: done
Yes. According to the Upstart Cookbook, it is executed with -e (but no -x). So
if a service fails to start, vdsmd is not started. From my debugging
experience, when I make a mistake in the script, it does not continue, and
vdsmd fails to start.
http://upstart.ubuntu.com/cookbook/#develop-scripts-using-bin-sh
Line 23: "@LIBEXECDIR@/vdsmd_init_common.sh" --pre-start
Line 24: end script
Line 25:
Line 26: # All commands called inside this script section except the daemon
itself
--
To view, visit http://gerrit.ovirt.org/17812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id68ec0197bd1e09100f5da96ac4db24f2b90753a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
