Federico Simoncelli has posted comments on this change. Change subject: Removing validate sd from spm verbs which calls ckvg and refreshes the domain metadata on the spm even though the spm already controls the changes (i.e. a lot of redundant time is wasted) ......................................................................
Patch Set 4: Code-Review-1 (2 comments) .................................................... File vdsm/storage/hsm.py Line 1670: def uploadImage(self, methodArgs, spUUID, sdUUID, imgUUID, volUUID=None): Line 1671: """ Line 1672: Upload an image to a remote endpoint using the specified method and Line 1673: methodArgs. Line 1674: """ As in the other cases this should remain as: sdCache.produce(sdUUID) in order to fail early before the task is started. We know it's racy but either we remove it from the other commands as well or we keep it (no reason to make this different). Line 1675: pool = self.getPool(spUUID) Line 1676: # NOTE: this could become an hsm task Line 1677: self._spmSchedule(spUUID, "uploadImage", pool.uploadImage, Line 1678: methodArgs, sdUUID, imgUUID, volUUID) Line 1681: def downloadImage(self, methodArgs, spUUID, sdUUID, imgUUID, volUUID=None): Line 1682: """ Line 1683: Download an image from a remote endpoint using the specified method Line 1684: and methodArgs. Line 1685: """ As in the other cases this should remain as: sdCache.produce(sdUUID) in order to fail early before the task is started. We know it's racy but either we remove it from the other commands as well or we keep it (no reason to make this different). Line 1686: pool = self.getPool(spUUID) Line 1687: # NOTE: this could become an hsm task, in such case the LV extension Line 1688: # required to prepare the destination should go through the mailbox. Line 1689: self._spmSchedule(spUUID, "downloadImage", pool.downloadImage, -- To view, visit http://gerrit.ovirt.org/18275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf597a9e53dad04ad7a01fc1d5ceb8a180a542f2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
