Bala.FA has posted comments on this change.
Change subject: gluster: Get size information of a gluster volume
......................................................................
Patch Set 5:
(2 comments)
Mounting a volume locally would be a pain to maintain ie
1. when mount happens?
2. when umount happens?
3. What if there is a stale mount?
4. What if the volume is been deleted?
....................................................
File client/vdsClientGluster.py
Line 715: 'Returns status of all gluster services if serviceName
is '
Line 716: 'not set'
Line 717: '(swift, glusterd, smb, memcached)'
Line 718: )),
Line 719: 'glusterVolumeSizeInfoGet': (
I feel glusterVolumeStatsGet name is similar to glusterVolumeStatus. Stats and
Status are quite similar. I would prefer different name
Line 720: serv.do_glusterVolumeSizeInfoGet,
Line 721: ('volumeName=<volume name> [humanReadable=<yes|no>]',
Line 722: 'Returns total, free and used space(bytes) of gluster
volume'
Line 723: )),
....................................................
File vdsm.spec.in
Line 1271: %dir %{_datadir}/%{vdsm_name}/gluster
Line 1272: %doc COPYING
Line 1273: %{_datadir}/%{vdsm_name}/gluster/api.py*
Line 1274: %{_datadir}/%{vdsm_name}/gluster/vdsmapi-gluster-schema.json
Line 1275: %{_datadir}/%{vdsm_name}/gluster/gfapi.py*
+1
BTW what is the plan of using gfapi in storage domain? Does python bindings go
into glusterfs-api package?
Line 1276: %{_datadir}/%{vdsm_name}/gluster/hooks.py*
Line 1277: %{_datadir}/%{vdsm_name}/gluster/services.py*
Line 1278: %endif
Line 1279:
--
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
