Zhou Zheng Sheng has posted comments on this change.
Change subject: Catching exceptions in daemon adapter
......................................................................
Patch Set 5:
(2 comments)
@Alon OK.
....................................................
File init/sysvinit/vdsmd.init.in
Line 75: acquire_lock() {
Line 76: # todo: add additional flock on free fd
Line 77: if [ -f "$LOCK_FILE" ]; then
Line 78: return 1
Line 79: fi
Maybe chown to vdsm here?
Line 80: touch "$LOCK_FILE"
Line 81: trap cleanup SIGINT SIGHUP SIGTERM
Line 82: }
Line 83:
Line 140:
Line 141: "${VDSMD_INIT_COMMON}" --pre-start
Line 142:
Line 143: echo $"Starting up vdsm daemon: "
Line 144: NICELEVEL="${NICE_LOWEST}" daemon --user=vdsm
"@VDSMDIR@/daemonAdapter" \
Here daemon adapter is run as vdsm user, so it does not have the permission to
delete the lockfile created by root. I think we should change the permissions
in acquire_lock().
Line 145: -0 /dev/null -1 /dev/null -2 /dev/null --lockfile
"${LOCK_FILE}" --logerror "@VDSMDIR@/respawn" --minlifetime 10 \
Line 146: --daemon --masterpid "${RESPAWNPIDFILE}" "${VDSM_BIN}"
--pidfile "${PIDFILE}"
Line 147: RETVAL=$?
Line 148: [ "$RETVAL" -eq 0 ] && log_success_msg $"$prog start" ||
log_failure_msg $"$prog start"
--
To view, visit http://gerrit.ovirt.org/18810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib515b01f06331d744b40236af5a1b12a16c37871
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
